[9.x] Allow customised implementation of the SendQueuedMailable job - #45040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allow us to bind a different implementation of the built-in
SendQueuedMailablejob.For example...
Why?
We have a lot of emails that we send by implementing
ShouldQueueon the Mailable class. In all instances, we would like to use our own implementation of thehandle()method of the built-inSendQueuedMailablejob, which will enable us to handle exceptions in a more granular manner.For example, most of our emails have a
backoff()strategy and aretryUntil()value. Sometimes, we receive an exception via our 3rd party email provider which we know means the email is never going to be sent, so there is no point retrying it. We would just like to permanently fail that job at that point.Something like...
I know we could use our own job to do this, but it requires our team to always remember to dispatch the custom job, rather than just calling
send()on the Mailable.