[9.x] Replace model:show searched value with correct FQCN - #45160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, while using
php artisan model:showthe result features the name of the class in the exact way you wrote it.In PHP, class names as well as function/method names are case-insensitive, but it is considered good practice to them functions as they appear in their declaration. Therefore it makes sense to return the name of the class as intended, however, while drawing the developers attention to it.
Proof of concept
php artisan model:show RUleresults in the following:Explanation of work
This PR checks if the provided model name matches what would be returned and appends searched value while replacing the original with correct casing.
Result
Incorrect casing results in:
Initially correct casing results in: