[9.x] Fix aliasing with cursor pagination - #45188
Merged
Merged
Conversation
Member
|
Please describe the issue in detail. Mark as ready for review when done please. Thanks! |
taylorotwell
marked this pull request as draft
December 5, 2022 15:12
Contributor
Author
|
Currently the getOriginalColumnNameForCursorPagination function finds the first occurrence of "as" of a dynamic column with an alias. I found this issue using cursorPaginate with a column dynamic expression that get the différence between two dates which I then cast to a float. |
maximepvrt
marked this pull request as ready for review
December 5, 2022 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue if "as" is present in cursor pagination alias for casting a column value.