[9.x] Fix schedule:list crash when call() is given class-string#45306
Merged
Conversation
When creating schedule of the form:
```php
$this->schedule->call(FooCall::class);
$this->schedule->call([FooCall::class, 'fooFunction']);
```
Then the `ScheduleListCommand::getClosureLocation()` method would crash with:
```
TypeError
Cannot use "::class" on value of type string
```
This PR fixes it by adding checks for string `$callback` and returning that string instead of adding `::class` to it.
Tests for both single string and array callable syntax included.
Contributor
Author
|
Thank you to @lukeraymonddowning and @olivernybroe for help with the solution! 😊👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating schedule of the form:
Then the
ScheduleListCommand::getClosureLocation()method would crash with:This PR fixes it by adding checks for string
$callbackand returning that string instead of adding::classto it.Tests for both single string and array callable syntax included.