[9.x] Fix credentials check#45437
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, because of recent Testbench changes, some tests of our first party libraries fail:
https://github.com/laravel/fortify/actions/runs/3659211237/jobs/6441135700#step:5:21
This is because sometimes, a
nullpassword is sent through to theAbstractHasherclass to check. I believe that instead of fixing this in every library, we can fix this in Laravel itself.In the
EloquentUserProvider, when the password is taken from the credentials array we'll check if it'snull. If it is, then we'll automatically fail the check because it's not a valid password.