[9.x] Optimize whereKey method 🏃🏻♂️#45453
Merged
Merged
Conversation
imanghafoori1
force-pushed
the
where_key
branch
2 times, most recently
from
358bf37 to
7c20173
Compare
imanghafoori1
force-pushed
the
where_key
branch
from
7c20173 to
978cb5f
Compare
imanghafoori1
changed the title
whereKey methodwhereKey method 🏃🏻♂️
driesvints
added a commit
that referenced
this pull request
Jan 10, 2023
This reverts commit 8c6d066.
Member
|
We're reverting this as it's causing a breaking change when using arrays: #45582 |
Contributor
Author
|
Can I seek a fix to the reported bug and avoid the revert? |
Member
|
You're free to attempt a new PR 👍 |
Contributor
Author
|
I am seeking the root cause of that right now, Hopefully, I can find it within an hour or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
whereIntegerInRawperforms better, why not use it when filtering the numeric Primary-key columns?This change also improves higher-level methods like
findManyand etc, so their tests are updated.