[9.x] Method explodeExplicitRule working wrong with regex rule - Issue 45520#45555
Merged
taylorotwell merged 4 commits intolaravel:9.xfrom Jan 9, 2023
Merged
[9.x] Method explodeExplicitRule working wrong with regex rule - Issue 45520#45555taylorotwell merged 4 commits intolaravel:9.xfrom
taylorotwell merged 4 commits intolaravel:9.xfrom
Conversation
driesvints
approved these changes
Jan 9, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45520
This PR reverts a change that I made in PR #40941 (specifically this change), which attempted to handle regex rules containing pipes, if they were the only rule in the string. This didn't work as intended when a string rule contains a regex with subsequent rules (as displayed in PR #45520).
This revert returns the validator to its default and documented behaviour of requiring regex rules containing pipes be split into an array of rule strings.
I have also adjusted the tests to ensure this default behaviour is kept, and that we will be notified of such a change due to test failure.
Let me know if you would like anything adjusted, thanks for your time!