[9.x] Fixes 45582 issue 🔧#45584
Merged
Merged
Conversation
2899364 to
8297e9e
Compare
This was referenced Jan 10, 2023
8297e9e to
d6751cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #45582
Since the
Builder\Queryflattens the binding array before applying it a method likewhereIncan accept an associative array as its second argument (as demonstrated in the added tests).So to make
whereIntegerInRawcompatible withwhereInwe need to flatten the values before casting it to int.@staudenmeir
whereInmethod tries to avoid accepting nested arrays as$valueswith the check below, but it is not enough and can be bypassed with an input like this:and due to the above flattening, it will continue to work as if it was called like this: