[9.x] Add notFound helper to Http Client response#45681
Merged
Conversation
notFound helper to Http Client responsesnotFound helper to Http Client response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some syntactic sugar to the Http Client Response class.
In a project we had to use the following code to check if a response was
404 Not FoundYou could still replace the
404literal with a constantSymfony\Component\HttpFoundation\Response::HTTP_NOT_FOUND, but that adds a unnecessary dependency there.With this PR you can do the following, which is a bit cleaner.