Skip to content

[9.x] Ensures channel name matches from start of string - #45692

Merged
taylorotwell merged 1 commit into
laravel:9.xfrom
timacdonald:matching
Jan 18, 2023
Merged

[9.x] Ensures channel name matches from start of string#45692
taylorotwell merged 1 commit into
laravel:9.xfrom
timacdonald:matching

Conversation

@timacdonald

@timacdonald timacdonald commented Jan 18, 2023

Copy link
Copy Markdown
Member

This fixes a bug with the channel matching.

Previously 'customer.order.1' would match the pattern 'order.{id}' because it was not checking that the pattern started at the beginning (^) of the string.

Both of the additional data sets fail with the previous implementation.

@taylorotwell
taylorotwell merged commit f7a7a86 into laravel:9.x Jan 18, 2023
@timacdonald
timacdonald deleted the matching branch January 18, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants