[9.x] Ensure decimal rule handles large values#45693
Merged
taylorotwell merged 4 commits intolaravel:9.xfrom Jan 23, 2023
Merged
[9.x] Ensure decimal rule handles large values#45693taylorotwell merged 4 commits intolaravel:9.xfrom
taylorotwell merged 4 commits intolaravel:9.xfrom
Conversation
timacdonald
commented
Jan 18, 2023
| "require": { | ||
| "php": "^8.0.2", | ||
| "ext-json": "*", | ||
| "brick/math": "^0.10.2", |
Member
Author
There was a problem hiding this comment.
This was missed when fixing the decimal model cast.
f266cd3 to
5bd6010
Compare
timacdonald
commented
Jan 23, 2023
Comment on lines
-2324
to
+2326
| * @return mixed | ||
| * @return int|float|string |
Member
Author
There was a problem hiding this comment.
Tightening this return type, as I believe it can only return these types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validator does not currently handle arbitrary length floats when comparing the size of decimal numbers.
The following code currently passes when it should not...
This PR leans on
brick/mathfurther whenever we are comparing a value's size.