[9.x] Removes dependency on bcmath#45729
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Jan 20, 2023
Merged
Conversation
timacdonald
force-pushed
the
multiple-of
branch
from
c85031d to
809fc0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the existing tests pass, which has some tricky floating point math in it. I was unable to get it to fail with any additional testing. Seems to be a good replacement to me so we can ditch the bcmath requirement.
Documentation: laravel/docs#8467