Fix ValidationValidator not to accept terminating newline #45790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen #45769 merged and realize that these methods are probably accept unintended newlines.
The manual (PHP: Meta-characters) says that
$
matches not only the end of the string, but also the terminating newline.The
\A
and\z
pairs are safe because they always match leading and trailing ends regardless of mode.PHP: Escape sequences - Manual
I'm not a Laravel user, so I'm not too concerned with this issue. If more work is needed for compatibility, please close this PR and have someone else work on it again. thank you!