[9.x] Stringables for Translator class - #45874
Merged
taylorotwell merged 2 commits intoJan 31, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
stringablemethod to the Translator classReflectsClosurestrait to the Translator classgetmethod to return the object into a string.Why
This behaves precisely to how Stringables work with the Blade compiler. The use case for this is that sometimes it's a pain having to format everything before passing it to the
getmethod. Instead, the translator can handle the values as objects and convert them to strings.Notes
This won't cause conflicts or break anything, as it's all additional code. That said, there is no Facade for the Translator currently. This would be hard to document as a feature as the more visible method would be: