[9.x] Fixed missing_with and missing_with_all validation#45913
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Feb 2, 2023
erik-perri:missing-with-fix
Merged
[9.x] Fixed missing_with and missing_with_all validation#45913taylorotwell merged 1 commit intolaravel:9.xfrom erik-perri:missing-with-fix
missing_with and missing_with_all validation#45913taylorotwell merged 1 commit intolaravel:9.xfrom
erik-perri:missing-with-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
missing_withandmissing_with_allrules are failing validation whether or not the specified field is in the data array. This brings the logic in line with the other missing validators to match the documentation.Reproduction steps: