[9.x] Add missing php extensions in composer#45941
Conversation
|
Waiting on @timacdonald review. |
|
Update: I have done a once over of all sub-package splits and the top level composer. This was actually already on my list to dig into.
Here is how I have approached the decisions made for sub-package spits:
For the top-level
|
| "php": "^8.0.2", | ||
| "ext-json": "*", | ||
| "ext-filter": "*", | ||
| "ext-mbstring": "*", |
There was a problem hiding this comment.
framework/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
Lines 2352 to 2369 in d3a4cd2
framework/src/Illuminate/Validation/DatabasePresenceVerifier.php
Lines 103 to 114 in d3a4cd2
| "require": { | ||
| "php": "^8.0.2", | ||
| "ext-json": "*", | ||
| "ext-tokenizer": "*", |
There was a problem hiding this comment.
See usages of token_get_all, T_CLOSE_TAG, T_INLINE_HTML, T_OPEN_TAG, and T_OPEN_TAG_WITH_ECHO.
| }, | ||
| "suggest": { | ||
| "ext-PDO": "Required to use the database queue worker.", | ||
| "ext-filter": "Required to use the SQS queue worker.", |
There was a problem hiding this comment.
framework/src/Illuminate/Queue/SqsQueue.php
Lines 205 to 212 in d3a4cd2
| "suggest": { | ||
| "ext-PDO": "Required to use the database queue worker.", | ||
| "ext-filter": "Required to use the SQS queue worker.", | ||
| "ext-mbstring": "Required to use the database failed job providers.", |
There was a problem hiding this comment.
framework/src/Illuminate/Queue/Failed/DatabaseFailedJobProvider.php
Lines 56 to 65 in d3a4cd2
| } | ||
| }, | ||
| "suggest": { | ||
| "ext-fileinfo": "Required to use the Filesystem class.", |
There was a problem hiding this comment.
framework/src/Illuminate/Filesystem/Filesystem.php
Lines 450 to 453 in d3a4cd2
| "suggest": { | ||
| "ext-fileinfo": "Required to use the Filesystem class.", | ||
| "ext-ftp": "Required to use the Flysystem FTP driver.", | ||
| "ext-hash": "Required to use the Filesystem class.", |
There was a problem hiding this comment.
framework/src/Illuminate/Filesystem/Filesystem.php
Lines 175 to 178 in d3a4cd2
| } | ||
| }, | ||
| "suggest": { | ||
| "ext-filter": "Required to use the Postgres database driver.", |
There was a problem hiding this comment.
framework/src/Illuminate/Database/Query/Grammars/PostgresGrammar.php
Lines 225 to 251 in d3a4cd2
framework/src/Illuminate/Database/Query/Grammars/PostgresGrammar.php
Lines 666 to 677 in d3a4cd2
| } | ||
| }, | ||
| "suggest": { | ||
| "ext-pcntl": "Required to use signal trapping.", |
There was a problem hiding this comment.
framework/src/Illuminate/Console/Signals.php
Lines 77 to 82 in d3a4cd2
framework/src/Illuminate/Console/Signals.php
Lines 89 to 102 in d3a4cd2
framework/src/Illuminate/Console/Signals.php
Lines 77 to 82 in d3a4cd2
| } | ||
| }, | ||
| "suggest": { | ||
| "ext-filter": "Required to use the DynamoDb cache driver.", |
There was a problem hiding this comment.
framework/src/Illuminate/Cache/DynamoDbStore.php
Lines 484 to 495 in d3a4cd2
| } | ||
| }, | ||
| "suggest": { | ||
| "ext-hash": "Required to use the Ably and Pusher broadcast drivers.", |
There was a problem hiding this comment.
framework/src/Illuminate/Broadcasting/Broadcasters/AblyBroadcaster.php
Lines 107 to 114 in d3a4cd2
| "require": { | ||
| "php": "^8.0.2", | ||
| "ext-json": "*", | ||
| "ext-pdo": "*", |
There was a problem hiding this comment.
Search usages of \PDO, \PDOStatement, and \PDOException.
| } | ||
| }, | ||
| "suggest": { | ||
| "ext-pdo": "Required to use the database queue worker.", |
There was a problem hiding this comment.
framework/src/Illuminate/Queue/DatabaseQueue.php
Lines 256 to 280 in d3a4cd2
// cc @X-Coder264
| "illuminate/view": "self.version" | ||
| }, | ||
| "require-dev": { | ||
| "ext-gmp": "*", |
There was a problem hiding this comment.
I think we still need this in require-dev.
See this PR: #43959
Seems best to leave it as GMP objects have some quirks that this addresses and I can't replicate with standard classes.
| ], | ||
| "require": { | ||
| "php": "^8.0.2", | ||
| "ext-ctype": "*", |
There was a problem hiding this comment.
Required in:
illuminate/sessionilluminate/support
| "require": { | ||
| "php": "^8.0.2", | ||
| "ext-ctype": "*", | ||
| "ext-filter": "*", |
There was a problem hiding this comment.
Required in:
illuminate/routingilluminate/validationilluminate/supportilluminate/httpilluminate/pagination
Optional in:
illuminate/queueilluminate/cacheilluminate/database
| "php": "^8.0.2", | ||
| "ext-ctype": "*", | ||
| "ext-filter": "*", | ||
| "ext-hash": "*", |
There was a problem hiding this comment.
Required in:
illuminate/authilluminate/routingilluminate/cookieilluminate/encryption
Optional in:
illuminate/filesystemilluminate/broadcasting
| "ext-hash": "*", | ||
| "ext-mbstring": "*", | ||
| "ext-openssl": "*", | ||
| "ext-session": "*", |
There was a problem hiding this comment.
Required in:
illuminate/session
| "ext-mbstring": "*", | ||
| "ext-openssl": "*", | ||
| "ext-session": "*", | ||
| "ext-tokenizer": "*", |
There was a problem hiding this comment.
Required in:
illuminate/view
| } | ||
| }, | ||
| "suggest": { | ||
| "ext-apcu": "Required to use the APC cache driver.", |
Followup: #45848
add missing necessary (for testing) and suggested PHP extensions.