[9.x] fix pdo exception when rollbacking without active transaction#46017
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Feb 8, 2023
Merged
Conversation
Contributor
Author
|
This may fix:
I also note there is failing tests about dead lock not retried, but the assertion seems not about dead lock: it is just an attempt to commit without an existing pending transaction (which in my opinion is not related). Not sure if these tests should be refined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents an issue when trying to rollback when there is no active database transaction.
I faced this issue when I converted my tests suites (which uses
LazilyRefreshDatabasetrait) from SQLite (in memory) to MySQL, which seems to behave differently regarding the transaction verification (SQLite is more permissive).