[9.x] Add methods to Enumerable contract#46021
Conversation
|
is it not a breaking change to add methods to the interface? |
You think it will break something? |
|
Yes. If anyone is implementing the interface their code will break because they don't have the new methods that was added. New methods are usually only added to interfaces in major versions because of this. You can look at the laravel 8 and 9 upgrade guides to see this. 8.x 8.x/upgrade#the-castable-interface 9.x 9.x/upgrade#the-enumerable-contract |
This reverts commit 3b8057c.
|
I've reverted this PR as it indeed contains breaking changes to the method signature and adds methods to existing contracts. Please attempt to 10.x instead. |
Good, thanks |
Add missing methods to Enumerable contract PR: #45839