[9.x] Avoid mutating the $expectedLitener between loops on Event::assertListening#46095
Merged
taylorotwell merged 2 commits intoFeb 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading from Laravel
8.xto9.x, some of the assertions for theassertListeningfailed randomly.I observed that when iteration over the listeners for a given event, if a
Class[@]methodcallback (PostAutoEventSubscriber::class . '@handle') string is evaluated before any class-based listener (PostAutoEventSubscriber::class), it causes the assertion to fail wrongfully.This happens because after the callback string is evaluated, the
$expectedListeneris normalized for the comparison. It causes the subsequent iteration to compare the$actualListenerwith the changed$expectedListenerfrom the previous one.You can attest that by changing the order in which the listeners are bound in the
tests/Integration/Events/EventFakeTest.phpfrom:To:
To solve the issue, we're just "caching" the normalized form of the expected listeners to avoid mutability between the iteration loops.