[9.x] Removes unnecessary creatable API singleton parameter - #46677
Merged
taylorotwell merged 1 commit intoApr 4, 2023
Conversation
Collaborator
|
This is strictly speaking a breaking change, so should go to master. In any case this is not a bug fix, so 9.x would not be appropriate. |
Collaborator
|
Oh, catching up on the other PR. I guess this is a bug fix. ;) |
Contributor
Author
|
I guess it could be breaking if someone is passing a value there... We could also add a comment in the parameter stating that the feature isn't there so people don't spam the optimize:clear command like maniacs thinking that they're cached 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently the
creatable()anddestroyable()methods in an API singleton resource route registartion accept boolean parameters that aren't taken into consideration later.Possible solution
Removal of these parameters as suggested here