[9.x] Fix PHPStan description of Closure returning a union type#47352
Merged
Conversation
driesvints
approved these changes
Jun 5, 2023
driesvints
left a comment
driesvints
left a comment
Member
There was a problem hiding this comment.
Hey @ondrejmirtes. 9.x is fine, thank you!
driesvints
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed
Closureandcallabletype description in PHPStan 1.10.16 to be compatible with what you can write in PHPDoc (https://phpstan.org/writing-php-code/phpdoc-types#callables). Union types need to be put in parentheses, because without themcallable(): string|nullmeans(callable(): string)|null.This breaks tests in
laravel/frameworkso I'm sending a PR to fix them.I wasn't sure which branch to pick. I chose 9.x because I figured it'll get merged to 10.x too (where the same issue is present).
Cheers 👍