[10.x] Add WithoutRelations attribute for model serialization - #47989
Merged
Conversation
Contributor
|
#47097 I offered this exact same feature a few months ago and it was closed. Would love to see something like this get to merged, as it's very useful. |
Contributor
Author
|
@cosmastech Ah, missed that PR. That doesn't give me much hope for this version. Will leave it here for now anyway tho |
Member
|
Please mark this as ready for review if you want one. Draft PRs aren't looked at. Thanks! |
Neol3108
marked this pull request as ready for review
August 9, 2023 06:14
Member
|
Love this. |
Contributor
|
Hi @Neol3108 is it possible to use this attribute for |
Contributor
Author
|
@siarheipashkevich yea sure, anything that uses the SerializesModels trait. |
Contributor
|
@Neol3108 what do you think about adding this to the documentation? |
Contributor
Author
|
@siarheipashkevich I mean, it's fine by me. Feel free to PR, Taylor will have to judge I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all,
I normally serialize my models without their relations, I've had some issues with circular dependencies and often don't even need them after unserialization. I usually do this by calling
withoutRelationson the model(s) in my constructor like this:There is however no way to do this with property-promotion. And apart from that I like to keep my job (etc.) constructors as slim as possible.
The following is possible with this PR:
I don't know if my approach is the best but it's the first that came to mind.
I'm curious to know what you think.