lazyById doesn't check availability of id (alias) column in database response and silently ends up with endless loop. chunkById does. - #48436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lazyByIddoesn't check availability of id (alias) column in database response and silently ends up with endless loop if DB query has more than 1 page of results. It happens if we don't select alias column.If we use this code (we don't select
idcolumn):So
foreachwill fall into endless loop and never ends if there are more than 1 page of results.You can say that it's programmer's responsibility to include
idin select butchunkByIdhas this check andlazyByIddocumentation doesn't say anything aboutidis required.In the
chunkByIdwe have this code which verifies that response hasidcolumn.It seems logical to me to add such a check to
lazyByIdas well.Initial issue: #48401