[10.x] Convert Expression to string for from in having subqueries - #48525
Merged
Merged
Conversation
tpetry
reviewed
Sep 26, 2023
ikari7789
force-pushed
the
get-from-expressions-string
branch
from
September 26, 2023 06:07
fc01137 to
2c31616
Compare
ikari7789
force-pushed
the
get-from-expressions-string
branch
from
September 26, 2023 06:08
2c31616 to
2591bbf
Compare
taylorotwell
marked this pull request as draft
September 26, 2023 21:29
tpetry
reviewed
Sep 27, 2023
tpetry
left a comment
tpetry
left a comment
Contributor
There was a problem hiding this comment.
Looks good now but didn't run it myself.
Contributor
Author
|
@tpetry thank you for your check. If there's anything more for me to help, please let me know. I haven't contributed to Laravel much so not too familiar with the typical flow. |
ikari7789
marked this pull request as ready for review
September 28, 2023 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to override the having from inside of the
whereHaving()callback will fail due to the removal of__toString()logic with Laravel 10.x.This adds back the ability to override the local table with a subquery in the having, which worked on previous versions of Laravel before 10.x.