[10.x] Remember the job on the exception#48830
Merged
taylorotwell merged 5 commits intolaravel:10.xfrom Oct 30, 2023
Merged
Conversation
Jubeki
reviewed
Oct 27, 2023
Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com>
Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com>
driesvints
requested changes
Oct 27, 2023
Member
|
@timacdonald looks good. What are your thoughts on the job having a large payload and thus filling up logs when being reported? |
Co-authored-by: Dries Vints <dries@vints.io>
Member
Author
|
@driesvints my understanding is that custom properties on exceptions are ignored when reporting or logging. I've never seen attaching a property to an exception class cause any issues. See also: #47223 (comment) |
Member
|
@timacdonald yup, you're totally right! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these exceptions are triggered they pass through the applications handlers reporting piping.
It is be common for a certain type of job to be okay to timeout and be treated "special", e.g., log it but not to a 3rd party error monitoring.
Currently the only way to do this is to check the error message, .e.g.,
While not the end of the world, it feels a flaky and yuck. This exposes the job on the exception.