[10.x] Do not use app() Foundation helper on ViewServiceProvider

[rodrigopedra]

PR #51450 makes use of the app() helper to solve the view engine resolvers leaking memory issue.

The app() is provided by the Foundation component, while the fix was made into the View component.

Currently, the Foundation component is not a dependency of the View component.

This PR

• Replaces the app() calls with Container::getInstance() calls where appropriate

Note that the View component already requires the Container component, and that the app() helper code basically delegates to Container::getInstance():

framework/src/Illuminate/Foundation/helpers.php

Lines 116 to 123 in 21e6d31

	function app($abstract = null, array $parameters = [])
	{
	if (is_null($abstract)) {
	return Container::getInstance();
	}
	return Container::getInstance()->make($abstract, $parameters);
	}

No tests were added.

[rmn-eloha-jouny]

Hello @taylorotwell and @rodrigopedra !

This commit is not included into the version v10.48.11 of the standalone package https://github.com/illuminate/view/commits/v10.48.11 and this is breaking some of my dependencies.

Is this possible to release a new version with it please ?

[driesvints]

@rmn-eloha-jouny heya. I found the root cause of this but we're still thinking on how to address this. Rest assured that this change will be added to tomorrow's release.

[rmn-eloha-jouny]

@driesvints Thanks for the quick response!