Add compatible query type to Model::resolveRouteBindingQuery#52339
Merged
taylorotwell merged 2 commits intolaravel:10.xfrom Aug 1, 2024
sebj54:10.x
Merged
Add compatible query type to Model::resolveRouteBindingQuery#52339taylorotwell merged 2 commits intolaravel:10.xfrom sebj54:10.x
Model::resolveRouteBindingQuery#52339taylorotwell merged 2 commits intolaravel:10.xfrom
sebj54:10.x
Conversation
Contributor
|
10 is closed for features. you should go for 11. |
Contributor
Author
|
Are you sure? To me it's more a bug fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I just added a compatible type to the
Model::resolveRouteBindingQuerymethod.I'm not sure if I chose the correct branch though, but it seems compatible with version 10 to me.
I tested the change in my project (with PHPStan level 9) and it has no warning.