[11.x] Add Illuminate\Support\enum_value to resolve BackedEnum or UnitEnum to scalar

[crynobone]

No description provided.

[rodrigopedra]

Not a fan of the name, maybe unbox()?

Suggestion comes from my old Java days:

https://docs.oracle.com/javase/tutorial/java/data/autoboxing.html

[taylorotwell]

Even something super explicit like "enum_value" would be fine with me since this will mainly be used internally and not really be user facing.

[shaedrich]

What about toScalar()?

[jayan-blutui]

Just updated to Laravel 11.28. After running some tests in my application I noticed that this PR introduces an issue where empty arrays [] are treated as null when running the following assertion in PEST. It seems like the enum_value function is internally calling a transform function which then converts the [] value to null.

use Illuminate\Testing\Fluent\AssertableJson;

->assertJson(fn (AssertableJson $json) => $json->whereType('id', 'string')
    ->where('object', 'menu')
    ->where('name', 'Primary')
    ->where('handle', 'primary')
    ->has('items', 2)
    ->has('items.0', fn (AssertableJson $json) => $json->whereType('id', 'string')
        ->where('object', 'menu_item')
        ->where('label', 'Home')
        ->where('url', '/')
        ->where('active', true)
        ->where('opens_new_tab', false)
        ->where('items', []) // Issue occurs here
        ->where('order', 0)
        ->etc()
    )
    ->has('items.1.items.0', fn (AssertableJson $json) => $json->whereType('id', 'string')
        ->where('object', 'menu_item')
        ->where('label', 'Payments')
        ->where('url', '/payments')
        ->where('active', true)
        ->where('opens_new_tab', false)
        ->where('items', []) // Issue occurs here
        ->where('order', 0)
        ->etc()
    )
    ->etc()
);

This check will return the following error:

Property [items.0.items] does not match the expected value.
Failed asserting that Array &0 [] is identical to null.

[grantholle]

Even something super explicit like "enum_value" would be fine with me since this will mainly be used internally and not really be user facing.

Any reason why it won't be added as a general helper? I find this really clever and useful to implement similar functionality in projects (similar to toValue in Vue-land).

[crynobone]

We want to limit it's usecase only to what's needed for the Framework.

[grantholle]

Couldn't the same could be said about any helper? Seems odd that this one is isolated as internal. It's a good function, let it have its moment 😆 .

Thanks anyway...

[crynobone]

Not exactly, as internal function we can create breaking change at any time and it's fine as long as it met Framework requirements. We also wouldn't need to consider any additional use-case by community other than use-case required by the Framework.

[grantholle]

That's fair. Given its simplicity, hopefully one day you'll reconsider 👍

For now it's copy + paste for me! Thanks again @crynobone