[11.x] Ensure where with array respects boolean#53147
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Oct 14, 2024
Merged
[11.x] Ensure where with array respects boolean#53147taylorotwell merged 1 commit intolaravel:11.xfrom
where with array respects boolean#53147taylorotwell merged 1 commit intolaravel:11.xfrom
Conversation
timacdonald
added a commit
to timacdonald/framework
that referenced
this pull request
Oct 15, 2024
taylorotwell
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit d62e92d.
timacdonald
added a commit
to timacdonald/framework
that referenced
this pull request
Oct 17, 2024
This reverts commit d62e92d.
|
I am currently working on an upgrade to L11, and came across the exception |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to create
wherequeries with an array. The array may be a hash map or a list.There
wheremethod accepts a boolean for the query, e.g.,AND,OR. The boolean is respected for the hash map but is ignored for the list.This PR ensures that the boolean is respected for both approaches.
User::where([ 'name' => 'Tim', 'verified' => true, ], boolean: 'or'); // select * from users where (name = 'Tim' or verified = 1) User::where([ ['name', 'Tim'], ['created_at', '>', now()->startOfYear()], ], boolean: 'or'); - // select * from users where (name = 'Tim' and created_at > '2024-01-01') + // select * from users where (name = 'Tim' or created_at > '2024-01-01')