Skip to content

[11.x] feat: restore type-narrowing bahavior for throw_* helpers#53164

Merged
taylorotwell merged 1 commit into
laravel:11.xfrom
crishoj:restore-type-narrowing
Oct 15, 2024
Merged

[11.x] feat: restore type-narrowing bahavior for throw_* helpers#53164
taylorotwell merged 1 commit into
laravel:11.xfrom
crishoj:restore-type-narrowing

Conversation

@crishoj

@crishoj crishoj commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Follow-up to #53154 from yesterday, based on input from @calebdw.

Restore the type-narrowing behavior of throw_if / throw_unless when passed a strictly boolean condition:

/** @var float|int $foo */
throw_if(is_float($foo));
assertType('int', $foo);

@taylorotwell taylorotwell merged commit ddfbbf0 into laravel:11.x Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants