Skip to content

[11.x] Improves PHP 8.4 compatibility#53182

Merged
taylorotwell merged 4 commits into11.xfrom
php84-compat-1
Oct 16, 2024
Merged

[11.x] Improves PHP 8.4 compatibility#53182
taylorotwell merged 4 commits into11.xfrom
php84-compat-1

Conversation

@crynobone
Copy link
Member

@crynobone crynobone commented Oct 16, 2024

CleanShot 2024-10-16 at 13 29 57

Notice this while adding PHP 8.4 support to laravel/pail

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review October 16, 2024 05:29
crynobone and others added 2 commits October 16, 2024 14:03
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@flavio-schoute
Copy link
Contributor

flavio-schoute commented Oct 16, 2024

@crynobone Is it correct that we all need to update al these method properties? Otherwise I will create a script to update them in batches.

Where we use like: $methodProperty = null

CleanShot 2024-10-16 at 11 52 29

@crynobone
Copy link
Member Author

That's doesn't require any changes. Please read what's new on PHP 8.4 for further detail

php:
preset: laravel
version: 8.2
enabled:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could update the Laravel preset to include this, instead, if you'd prefer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's would be great

@taylorotwell taylorotwell merged commit 3eb58f1 into 11.x Oct 16, 2024
@taylorotwell taylorotwell deleted the php84-compat-1 branch October 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants