[11.x] fix: allows injection using multiple interfaces with the same concrete implementation#53275
Merged
Merged
Conversation
Contributor
Author
|
Whoops, missed some failing tests. I'll get these fixed up. |
Member
|
Seems like we would want a test for this new behavior I think. |
…tion can be injected in controllers
Contributor
Author
|
Should be good now. I wasn't 100% sure if the test fit into any of the existing test files, so I added a new one. |
Member
|
Sorry for delay - thanks. 👍 |
Contributor
|
This caused an issue with route model binding. See: #53952 @jamiethorpe since you authored this PR, maybe you could give some insight? It would be appreciated! 🙏 |
Member
|
Reverting for now. |
Contributor
|
Thank you |
Contributor
Author
|
@jasonvarga This looks like an oversight on my part. I probably won't get to it until after the holidays, but I'll take another stab at it and and tests to make sure the refactor doesn't break the same functionality. Thanks for finding that 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 53110
This allows multiple interfaces to be injected when they use the same concrete implementation. This change also prevents injecting the same interface twice, but I'm not sure if that's necessary.