[11.x] use exists() instead of count()#53328
Merged
taylorotwell merged 2 commits intolaravel:11.xfrom Oct 29, 2024
Merged
Conversation
we only need to check for existence of a record here, not for the actual count, and `exists()` is generally more performant than a count.
- add an "exists" assertions, and update `mockCountBuilder()` to accept this first, and adjust all the calls to it. - I thought about renaming `mockCountBuilder()` to `mockBuilder()`, which would probably be a little clearer now, but I wanted to keep this easy to review. if this is accepted, I'd probably go back and make that semantic change separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we only need to check for existence of a record here, not for the actual count, and
exists()is generally more performant than a count.