[11.x] Handle HtmlString constructed with a null#53367
Merged
taylorotwell merged 1 commit intoNov 1, 2024
Merged
Conversation
Contributor
Yes. Even if parameters type hints were used, you'd have to sanitize any values before passing down to the constructor. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I managed to construct an
HtmlStringwith anullvalue. I realise that inserting anullvalue into anHtmlStringis pretty bad and I should have sanitized the value properly beforehand.However, since this is possible, I believe that the
__toString()andisEmptymethods should gracefully handlenullvalues. This will prevent a type error exception when getting the string value and correctly reflect that theHtmlStringis empty.