[11.x] Add support for syncing associations with array or base collection of models#53495
Merged
taylorotwell merged 3 commits intoNov 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a code review for a teammate’s automated tests, I proposed the following change:
However, he encountered an error when attempting to implement this change, despite I was very sure that I used
syncwith models before.It appears that the current implementation of
parseIdsdoesn't support passing models unless they are passed inside an Eloquent collection, so, to make it consistent, I updated the implementation to work with an array or base collection of models.This will also be beneficial for situations when you already have an array of models:
Furthermore, it seems that there are currently no tests that cover the scenario of passing an Eloquent collection to the
syncmethod, so I added a check for it inside my newly added test.