[11.x] Removing unused var assignment in Illuminate Router

[Carnicero90]

It won't benefit any end user, it can't break any existing feature since the variable was unused, it doesn't make building applications easier: I just noticed that while debugging some stuff in the vendor of my application.

[osbre]

@Carnicero90 It was meant to help with readability. I think it came from the days when there were no named arguments in PHP. nowadays it should be:

$route->setAction($this->mergeWithLastGroup(
    $route->getAction(),
    prependExistingPrefix: false,
));

[Carnicero90]

Aaah, I see. Here you go.

[rodrigopedra]

Named arguments are not covered by Laravel's backwards compatibility guidelines. We may choose to rename function arguments when necessary in order to improve the Laravel codebase. Therefore, using named arguments when calling Laravel methods should be done cautiously and with the understanding that the parameter names may change in the future.

Reference: https://laravel.com/docs/11.x/releases#named-arguments

[Carnicero90]

Named arguments are not covered by Laravel's backwards compatibility guidelines. We may choose to rename function arguments when necessary in order to improve the Laravel codebase. Therefore, using named arguments when calling Laravel methods should be done cautiously and with the understanding that the parameter names may change in the future.

Reference: https://laravel.com/docs/11.x/releases#named-arguments

Seems to be more of a user guide though. Still, it doesnt matter all that much, since this is a pretty useless pr overall.