[11.x] Fix: Prevent invalid AWS credentials options being created#53633
[11.x] Fix: Prevent invalid AWS credentials options being created#53633taylorotwell merged 1 commit intolaravel:11.xfrom
Conversation
Improves on 909ea24 which could create credentials arrays with only a token
laravel/framework#53633 fixes laravel side here but it won't be patched into older versions
|
Hey Robert! Can you elaborate a bit on this one? What is the problem with the current code? We use this logic quite a bit with Vapor so just want to make sure we aren't breaking something here. Please mark as ready for review when you respond so I see it again. |
|
An upstream bug in https://github.com/brefphp/laravel-bridge was causing credentials to be generated for AWS services with just a Only the code on If preferred I can remove the changes to:
|
Improves on 909ea24 which could create credentials arrays with only a token