event name & listener callback types

[rudiedirkx]

$callback type is currently QueuedClosure|\Closure|string|array, which includes a lot, but not invokable classes. I changed it to QueuedClosure|class-string|array|callable which does include invokable classes (callable), and is more specific about the string (class-string). I'm not sure though. Let's run some tests.

[einar-hansen]

The changes to the listen method on the Dispatcher class is making PHPStan complain, are you certain about this change @rudiedirkx? The second parameter should/could allow for a string (not limited to class-string), since it's possible to invoke a method on a class using a string. Example from a subscriber class that I have:

public function deleting(ProductDeletingEvent $event): void
{
   ...code
}

public function subscribe(Dispatcher $dispatcher): void
{
    $dispatcher->listen(
        ProductDeletingEvent::class,
        self::class.'@deleting',
    );
}

[rudiedirkx]

@einar-hansen I would listen like this:

$dispatcher->listen(ProductDeletingEvent::class, self::deleting(...));

instead of the @, but you are right, string should still be a valid $callback, because Laravel accepts the @ syntax. I never use that, so my stan didn't complain, and I do use invokable classes, so my stan got better.

@taylorotwell This should be improved or reverted. class-string and string are both valid $callback, not just class-string.

@einar-hansen Or a new PR that improves this one? :)

[einar-hansen]

Thanks @rudiedirkx.

I ended up updated my code to match the example in the Laravel docs, so I'm fine. I'll send in PR when things calm down around Christmas time. Thanks for a good PR 😄