[11.x] Fix SyntaxError on Vite prefetch with empty assets#53659
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Nov 25, 2024
Merged
[11.x] Fix SyntaxError on Vite prefetch with empty assets#53659taylorotwell merged 1 commit intolaravel:11.xfrom
SyntaxError on Vite prefetch with empty assets#53659taylorotwell merged 1 commit intolaravel:11.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
$assetsis empty and the'aggressive'strategy is applied in the Vite prefetcher, the resulting JS includes the fragment:When executed this yields an error
Uncaught SyntaxError: expected expression, got ']'. Although not hurtful (there is nothing to do anyways), it is still a slight nuisance.This MR fixes the issue by adding a semicolon to eagerly terminate the previous statement. An alternative way would be to rewrite the entire statement to not write any html at all when
$assetsis empty, given that there is nothing to do.