[11.x] Add PausePrompt fallback#53660
Merged
taylorotwell merged 2 commits intolaravel:11.xfrom Nov 25, 2024
jwpage:pauseprompt_fallback
Merged
[11.x] Add PausePrompt fallback#53660taylorotwell merged 2 commits intolaravel:11.xfrom jwpage:pauseprompt_fallback
taylorotwell merged 2 commits intolaravel:11.xfrom
jwpage:pauseprompt_fallback
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback for the
\Laravel\Prompts\PausePromptto theIlluminate\Console\Concerns\ConfiguresPromptsto fallback to using a Symfony question.This allows users to use
$pendingCommand->expectsQuestion('Press enter to continue', '')in their tests when there is aPausePromptin their command.The fallback discards the result of the question and instead uses the result of the underlying
PausePrompt::value(), as is the expected behaviour when not using the fallback.In the test, it adds the current test case instance into the test command constructor so that we can assert upon the prompt's return value.