[11.x] groupBy() return type phpdoc #53684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current phpdoc, the return type of
Collection::groupBy()is assumed to be a collection with the same values as the original one. However, when the grouping is specified with an array of two or more keys (e.g.,$collection->groupBy(['key1', 'key2'])), the result is a multi-level collection (i.e., a collection of collections).This PR changes the return type so that it doesn't make assumptions on the collection values when the grouping is specified with an array - while leaving it as it is when it's a single key or a function.
If this PR is merged, I'll make a corresponding PR to larastan, as it contains stubs for these classes/interfaces.