[11.x] Add ability to transform Http\Client\Response into Fluent#53771
Merged
taylorotwell merged 3 commits intoDec 6, 2024
Conversation
stevebauman
commented
Dec 5, 2024
| */ | ||
| public function fluent($key = null) | ||
| { | ||
| return new Fluent((array) $this->json($key)); |
Contributor
Author
There was a problem hiding this comment.
We have to make sure we cast this to an array, otherwise PHP will throw a warning on Fluent::__construct due to attempting to iterate over something non-iterable (if the returned value is not an array):
framework/src/Illuminate/Support/Fluent.php
Lines 35 to 40 in 7db7ea9
browner12
pushed a commit
to browner12/framework
that referenced
this pull request
Dec 10, 2024
…aravel#53771) * Add ability to transform a response into a fluent instance * Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
fluentmethod on theHttp\Client\Responseclass to be able to transform response data into aFluentinstance: