Skip to content

[11.x] Improves Collection support for enums using firstWhere() and value()#53777

Merged
taylorotwell merged 4 commits into11.xfrom
11/test-53635
Dec 6, 2024
Merged

[11.x] Improves Collection support for enums using firstWhere() and value()#53777
taylorotwell merged 4 commits into11.xfrom
11/test-53635

Conversation

@crynobone
Copy link
Copy Markdown
Member

@crynobone crynobone commented Dec 6, 2024

Fixes #53676

crynobone and others added 4 commits December 6, 2024 20:54
…nd `value()`

Fixes #53676

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review December 6, 2024 13:14
@taylorotwell taylorotwell merged commit b8bb5e9 into 11.x Dec 6, 2024
@taylorotwell taylorotwell deleted the 11/test-53635 branch December 6, 2024 18:54
browner12 pushed a commit to browner12/framework that referenced this pull request Dec 10, 2024
…nd `value()` (laravel#53777)

* [11.x] Improves `Collection` support for enums using `firstWhere()` and `value()`

Fixes laravel#53676

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

* Apply fixes from StyleCI

* wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

* wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

---------

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enums are not compatible with Collection::value()

3 participants