[11.x] Make mailables tappable#53788
Merged
Merged
Conversation
browner12
pushed a commit
to browner12/framework
that referenced
this pull request
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been enjoying using the
tapmethod from theIlluminate\Testing\TestResponseclass, when I got a little logics around assertions.The
Illuminate\Mail\Mailableclass contains assertion methods. It would be nice to also make it tappable.I have the following real-life example from my organization:
As a global business, we want to display correct branch address in our emails depending on the customer's location.
I would prefer to do all assertions in one go: