[11.x] Remove usage of compact() in Container

[KennedyTedesco]

This removes the only compact() function call in Container and replaces it with a direct array, saving a function call.

[andrey-helldar]

Benchmark::dd([
    'compact' => function () {
        $foo = 'foo';

        $item = compact('foo');

        return $item['foo'];
    },
    'array'   => function () {
        $foo = 'foo';

        $item = ['foo' => $foo];

        return $item['foo'];
    },
], 10000);

$ art foo
array:2 [
  "compact" => "0.001ms"
  "array" => "0.001ms"
]

The compact function reads easier ¯_(ツ)_/¯

[KennedyTedesco]

The performance difference is negligible (even though the array literal requires fewer opcodes to be executed).

Overall, I have the opposite opinion: I always prefer the array literal version because:

• It's more explicit and easier to read (in my opinion).
• It requires fewer opcode operations.
• It's more IDE-friendly for static analysis and AST tools like Rector etc (even though static analyzers can handle the compact function).

I'm 100% in favor of using the array literal version, especially in this case where only two values are being handled.

[andrey-helldar]

In this case, the phrase “all felt-tip pens are different for taste and color” applies 🙂