[11.x] Add pingOnSuccessIf & pingOnFailureIf to Schedule handling#53795
Merged
taylorotwell merged 3 commits intolaravel:11.xfrom Dec 8, 2024
lucacastelnuovo:patch-1
Merged
[11.x] Add pingOnSuccessIf & pingOnFailureIf to Schedule handling#53795taylorotwell merged 3 commits intolaravel:11.xfrom lucacastelnuovo:patch-1
taylorotwell merged 3 commits intolaravel:11.xfrom
lucacastelnuovo:patch-1
Conversation
|
Hi @lucacastelnuovo ! |
Contributor
Author
I'm sorry, I don't understand the question. Could you clarify? |
I have submitted a pull request for the Laravel documentation regarding your new functions. Kindly review it here. |
Contributor
Author
Looks great, thank you. I forgot to do it myself. |
browner12
pushed a commit
to browner12/framework
that referenced
this pull request
Dec 10, 2024
…ravel#53795) * Add pingOnSuccessIf & pingOnFailureIf * [fix]: style error * Update Event.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
pingBeforeIf()exists. Which can be used like this:This PR proposes adding the same functionality to the
pingOnSuccessand thepingOnFailuremethods. (https://laravel.com/docs/11.x/scheduling#pinging-urls)This makes it possible to write the following code:
This is my first PR to the laravel/framework repo. Let me know if I did something wrong :)