[11.x] Require laravel/serializable-closure on Database component#53822
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Dec 10, 2024
Merged
Conversation
…a suggested package to a required package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
laravel/serializable-closurepackage is currently only suggested for the Database component. This PR moves it from a suggestion to a requirement.With recent updates, the package is getting pretty ingrained into Eloquent. With the merging of PR #52883, it is now used whenever a model is saved or deleted (via calls to
touchOwners()). This basically makes Eloquent unusable without the package, and breaks existing packages that use Eloquent in the Database component outside of the framework (Error: Class "Laravel\SerializableClosure\Support\ReflectionClosure" not found).This PR updates the
composer.jsonto require the package instead of just suggest it. I set the version requirements to match that found in the frameworkcomposer.jsonfile and the Queue component.Thanks,
Patrick