[11.x] Fix incorrect typechange in Illuminate\Database\Query\Builder#53841
Merged
taylorotwell merged 1 commit intolaravel:11.xfrom Dec 11, 2024
Merged
[11.x] Fix incorrect typechange in Illuminate\Database\Query\Builder#53841taylorotwell merged 1 commit intolaravel:11.xfrom
Illuminate\Database\Query\Builder#53841taylorotwell merged 1 commit intolaravel:11.xfrom
Conversation
jnoordsij
changed the title
Illuminate\Database\Query\Builder
Contributor
|
@jnoordsij You're absolutely correct. The wheres property is initialized as an empty array and should not have been marked as nullable. I initially added the nullable type during development but forgot to remove it before opening the PR. Thank you for catching that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #53793 various properties in the
Illuminate\Database\Query\Builderclass were marked as nullable as they have no initial value, thus defaulting tonull. However thewheresproperties is initialized with an empty array, thus already is an array on class construction and should never benull.