[11.x] Fixes Illuminate\Http\Response to output empty string if $content is set to null

[crynobone]

1. Symfony set the content to null for response()->noContent() https://github.com/symfony/http-foundation/blob/e88a66c3997859532bc2ddd6dd8f35aba2711744/Response.php#L246-L249
2. This cause issue with PSR-7 HTTP Stream in Octane

fixed laravel/octane#972

[rodrigopedra]

Why not just?

return parent::getContent() ?? '';

[rodrigopedra]

Also, for the same hash you linked the $this->setContent(null);, setContent() actually uses the null-coalescing operator to convert null to an empty string:

https://github.com/symfony/http-foundation/blob/e88a66c3997859532bc2ddd6dd8f35aba2711744/Response.php#L418-L423

Maybe the problem is something else?

[rodrigopedra]

Does octane calls Illuminate\Http\ResponseTrait@getOriginalContent(), the Response::$original property is stored unchanged, that might be the issue.

[crynobone]

I'm a little hesitant to follow Symfony style since their phpdoc indicate string|null while ours is mixed

Also with mixed we could potentially introduce breaking changes for application that expected that they can directly return null (maybe 🤔)

[rodrigopedra]

I agree, but our override at the end defers to theirs

From our current code null should end up being handled by parent::setContent($content); which already coalesces null to an empty string