pass options to migration events#54151
Merged
taylorotwell merged 2 commits intolaravel:11.xfrom Jan 13, 2025
Merged
Conversation
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #48801
I passed through the whole
$optionsarray to make it slightly more future proof in case there are other options added in the future.I had a few issues writing tests for it which is why
testMigrationEventsContainTheOptionsAndPretendTrueis a bit shorter but I also figure that the rollback event is tested intestMigrationEventsContainTheOptionsAndPretendFalseso doesn't necessarily need a duplicated test.I would also be interested in changing the base event for php 8 constructor property promotion which I can see being used in a few other classes in the framework but I didn't want to just jump into that bit without confirming it was okay.